Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Haml Setup #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Haml Setup #46

merged 1 commit into from
Aug 14, 2022

Conversation

Petercopter
Copy link
Contributor

Partial fix for #45

Will require changes in Syntax Tree as well

@kddnewton
Copy link
Member

Nice! This looks right. Let's get the other piece of this merged into syntax tree first and then we can merge this.

@Petercopter
Copy link
Contributor Author

Petercopter commented Aug 3, 2022

@kddnewton This is what I've got so far.

I added the onLanguage event like you mentioned, then I thrashed around a lot and added the documentSelector as well. That seems to get me to the point where VSCode is using Syntax Tree to trigger.

This may or may not be doing something in the config:

"[haml]": {
    "editor.defaultFormatter": "ruby-syntax-tree.vscode-syntax-tree"
  }

At this point I was going to switch over to Syntax Tree and try to figure out how to get Haml formatting working there, does that sound right?

Edit: You beat me! 👍 🎉

@Petercopter Petercopter changed the title WIP! Haml Setup Haml Setup Aug 10, 2022
@Petercopter
Copy link
Contributor Author

ruby-syntax-tree/syntax_tree#127 is merged :D

@kddnewton kddnewton merged commit b0036d1 into ruby-syntax-tree:main Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants